Bind collector: Adding support for new some v3 XML bind9 stats and JSON v1 #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

thardie wants to merge 1 commit into python-diamond:master

from thardie:bind9

Open

Bind collector: Adding support for new some v3 XML bind9 stats and JSON v1 #562

thardie wants to merge 1 commit into python-diamond:master from thardie:bind9

Conversation

@thardie

Copy link

@thardie thardie commented Dec 15, 2016

Bind 9.11 has removed the old XML (v2) interface. This adds some support for key statistics under /server section of new v3 XML and v1 JSON interface.

Querying the root of the XML interface can cause bind to stop answering queries for several hundred milliseconds. Querying /server XML only 4-5ms, and /server for JSON 1-2ms.

shortdudey123

shortdudey123 reviewed

Dec 15, 2016

View reviewed changes

src/collectors/bind/bind.py

'publish_view_bind': "",

'publish_view_meta': "",

'data_format': "Bind stats version:\n" +

" - xml_v2 (Original bind stats version from 9.5)\n" +

Copy link

Member

@shortdudey123 shortdudey123 Dec 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should pick xml or xml_v2 and make sure its consistent throughout

Copy link

Member

@shortdudey123 shortdudey123 Dec 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was corrected, thanks!

@shortdudey123

Copy link

Member

shortdudey123 commented Dec 15, 2016

Tests and doc need to be updated as well

@shortdudey123

Copy link

Member

shortdudey123 commented Dec 15, 2016

pep8 errors need to be addressed as well

@thardie thardie force-pushed the bind9 branch from e0622ad to 7123829 Compare

December 15, 2016 19:47

@thardie

Copy link

Author

thardie commented Dec 15, 2016

Ooops. Still need to do tests and docs.

@coveralls

Copy link

coveralls commented Dec 15, 2016

Coverage Status

Coverage decreased (-0.8%) to 58.937% when pulling 7123829 on thardie:bind9 into f4a523f on python-diamond:master.

@thardie thardie force-pushed the bind9 branch from 7123829 to f946865 Compare

December 15, 2016 20:09

@coveralls

Copy link

coveralls commented Dec 15, 2016

Coverage Status

Coverage remained the same at 59.729% when pulling f946865 on thardie:bind9 into f4a523f on python-diamond:master.

@thardie

Copy link

Author

thardie commented Dec 15, 2016

I don't have a python 2.6 environment to test this in. What's your stance on this feature not working in python 2.6?

@coveralls

Copy link

coveralls commented Dec 15, 2016

Coverage Status

Coverage remained the same at 59.729% when pulling e445af8 on thardie:bind9 into f4a523f on python-diamond:master.

@shortdudey123

Copy link

Member

shortdudey123 commented Dec 16, 2016

2.6 is still supported by the project technically, but i will let others speak to that point

shortdudey123

shortdudey123 reviewed

Dec 16, 2016

View reviewed changes

docs/collectors/BindCollector.md

- zonemgmt (Zone management requests/responses)<br>

- sockets (Socket statistics)<br>

- memory (Global memory usage)<br>

| list

Copy link

Member

@shortdudey123 shortdudey123 Dec 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mode change?
100644 → 100755

shortdudey123

shortdudey123 reviewed

Dec 16, 2016

View reviewed changes

docs/collectors/BindCollector.md

| list

publish_view_bind | False | | bool

publish_view_meta | False | | bool

data_format | xml_v2 | Bind stats version:<br>

Copy link

Member

@shortdudey123 shortdudey123 Dec 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table gets messed up, not sure whats the best way to handle it though

shortdudey123

shortdudey123 reviewed

Dec 16, 2016

View reviewed changes

src/collectors/bind/bind.py Outdated

'publish_view_bind': False,

'publish_view_meta': False,

'data_format': 'xml_v2',

'derivative': True,

Copy link

Member

@shortdudey123 shortdudey123 Dec 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have derivative in a separate PR

@thardie thardie force-pushed the bind9 branch from e445af8 to f946865 Compare

December 16, 2016 23:32


 Bind collector: Adding support for /server section of bind9

32ecfd2

for xml_v3 and json_v1

@thardie thardie force-pushed the bind9 branch from f946865 to 32ecfd2 Compare

December 16, 2016 23:33

@coveralls

Copy link

coveralls commented Dec 16, 2016

Coverage Status

Coverage remained the same at 59.729% when pulling 32ecfd2 on thardie:bind9 into f4a523f on python-diamond:master.

@shortdudey123 shortdudey123 added category: collector type: enhancement labels

Feb 8, 2017

@shortdudey123 shortdudey123 added collector: bind needs: documentation labels

Feb 17, 2017

Labels

category: collector collector: bind needs: documentation type: enhancement

3 participants

@thardie @shortdudey123 @coveralls

Bind collector: Adding support for new some v3 XML bind9 stats and JSON v1 #562

Are you sure you want to change the base?

Bind collector: Adding support for new some v3 XML bind9 stats and JSON v1 #562

Uh oh!

Conversation

@thardie thardie commented Dec 15, 2016

Uh oh!

@shortdudey123 shortdudey123 Dec 15, 2016

Choose a reason for hiding this comment

Uh oh!

@shortdudey123 shortdudey123 Dec 15, 2016

Choose a reason for hiding this comment

Uh oh!

shortdudey123 commented Dec 15, 2016

Uh oh!

shortdudey123 commented Dec 15, 2016

Uh oh!

thardie commented Dec 15, 2016

Uh oh!

coveralls commented Dec 15, 2016

Uh oh!

coveralls commented Dec 15, 2016

Uh oh!

thardie commented Dec 15, 2016

Uh oh!

coveralls commented Dec 15, 2016

Uh oh!

shortdudey123 commented Dec 16, 2016

Uh oh!

@shortdudey123 shortdudey123 Dec 16, 2016

Choose a reason for hiding this comment

Uh oh!

@shortdudey123 shortdudey123 Dec 16, 2016

Choose a reason for hiding this comment

Uh oh!

@shortdudey123 shortdudey123 Dec 16, 2016

Choose a reason for hiding this comment

Uh oh!

coveralls commented Dec 16, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants